Update code0 flow - #145
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Taurus’s dynamic flow sync to work with the newer code0-flow release by introducing an Aquila token configuration and passing it into the flow update client.
Changes:
- Bump
code0-flowdependency from0.0.29to0.0.30. - Add
AQUILA_TOKENto Taurus config and pass it intoFlowUpdateService::from_url(...). - Refresh
Cargo.lockto reflect the updated dependency graph.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/taurus/src/main.rs | Passes Aquila token into flow update sync during DYNAMIC startup. |
| crates/taurus/src/config/mod.rs | Adds aquila_token to Config and loads it from AQUILA_TOKEN. |
| Cargo.toml | Bumps code0-flow workspace dependency version. |
| Cargo.lock | Updates lockfile for code0-flow 0.0.30 and related deps. |
Comments suppressed due to low confidence (1)
crates/taurus/src/config/mod.rs:50
AQUILA_TOKENdefaults to the literal value "token". That makes it easy to accidentally run with an invalid/predictable credential (and can hide misconfiguration in production). Prefer defaulting to an empty string/None and explicitly failing (or warning) when running inDYNAMICmode without a real token, depending on whether auth is required.
nats_url: env_with_default("NATS_URL", String::from("nats://localhost:4222")),
aquila_url: env_with_default("AQUILA_URL", String::from("http://localhost:50051")),
aquila_token: env_with_default("AQUILA_TOKEN", String::from("token")),
with_health_service: env_with_default("WITH_HEALTH_SERVICE", false),
grpc_host: env_with_default("GRPC_HOST", "127.0.0.1".to_string()),
grpc_port: env_with_default("GRPC_PORT", 50051),
definitions: env_with_default("DEFINITIONS", String::from("./definitions")),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -110,6 +110,7 @@ async fn main() { | |||
| FlowUpdateService::from_url( | |||
| config.aquila_url.clone(), | |||
| config.definitions.clone().as_str(), | |||
There was a problem hiding this comment.
config.definitions.clone().as_str() creates an unnecessary temporary String just to immediately borrow it. Prefer borrowing the existing String (e.g., config.definitions.as_str() / &config.definitions) to reduce allocations and avoid confusing temporary-borrow patterns around an .await.
Suggested change
| config.definitions.clone().as_str(), | |
| config.definitions.as_str(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.